Skip to content

LLDB CMake: add option to link Swift content from Darwin toolchain #8647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

edymtt
Copy link

@edymtt edymtt commented Apr 27, 2024

This is a companion to swiftlang/swift#73255, and it's needed in some Apple internal configurations.

Addresses rdar://127113448

This is a companion to swiftlang/swift#73255, and
it's needed in some Apple internal configurations.

Addresses rdar://127113448
@edymtt edymtt requested a review from JDevlieghere as a code owner April 27, 2024 20:18
@edymtt
Copy link
Author

edymtt commented Apr 27, 2024

@swift-ci Please test

@edymtt
Copy link
Author

edymtt commented Apr 27, 2024

@swift-ci test llvm

@edymtt
Copy link
Author

edymtt commented Apr 28, 2024

The failure for "LLVM Test Linux Platform" and "Swift Test Linux Platform" is unrelated to this PR, since it happened also in another run for a different PR

/home/build-user/llvm-project/llvm/lib/MCCAS/MCCASObjectV1.cpp:2693:53: error: 'CompressedBuff' was not declared in this scope

Similarly, "LLVM Test macOS Platorm" fails the same was at the previous PR (according to the matching run)

Failed Tests (3):
  Clang :: CodeGen/ptrauth-debuginfo.c
  Clang :: CodeGenCXX/ptrauth-member-function-pointer.cpp
  Clang :: CodeGenCXX/ptrauth-virtual-function.cpp

The failure for "Swift Test macOS Platform" looks to be unrelated to this change (which affects LLDB and is inert by default)

/Users/ec2-user/jenkins/workspace/apple-llvm-project-pr-macos/branch-next/swift/include/swift/Basic/StableHasher.h:136:29: error: no member named 'endianness' in namespace 'llvm::support'; did you mean 'llvm::endianness'?
    constexpr auto endian = llvm::support::endianness::little;
                            ^~~~~~~~~~~~~~~~~~~~~~~~~
                            llvm::endianness

Same for "Swift Test Windows Platform"

C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\include\swift/Localization/LocalizationFormat.h(80): error C2065: 'little': undeclared identifier

@edymtt
Copy link
Author

edymtt commented Apr 28, 2024

To get more meaningful signal, cherry-picking preemptively this PR swift/release/6.0 and running testing there.

@edymtt
Copy link
Author

edymtt commented Apr 29, 2024

The matching 6.0 PR has run Swift PR testing successfully.

@edymtt edymtt merged commit ead278f into swiftlang:next Apr 29, 2024
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants