Skip to content

Add arrangeCXXMethodCall to the CodeGenABITypes interface. #9476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

hjyamauchi
Copy link

@hjyamauchi hjyamauchi commented Oct 28, 2024

Also add ExtParameterInfos to the argument list of arrangeFreeFunctionCall.

Cherrypick llvm#111597

Resolves swiftlang/swift#74866

Also add ExtParameterInfos to the argument list of
arrangeFreeFunctionCall.

Cherrypick llvm#111597
@hjyamauchi
Copy link
Author

@swift-ci please test

@hjyamauchi
Copy link
Author

@swift-ci please test

@hjyamauchi hjyamauchi marked this pull request as ready for review October 30, 2024 16:58
@hjyamauchi hjyamauchi requested a review from rjmccall October 30, 2024 16:58
@hjyamauchi
Copy link
Author

@rjmccall This is a cherrypick of llvm#111597 to release/6.0. Can you review?

Copy link

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very low risk; does not affect any currently-used code paths in either Clang or Swift.

@hjyamauchi
Copy link
Author

Hi @ravikandhadai can you review this PR along with swiftlang/swift#77261? This is to fix the windows arm64 compiler: swiftlang/swift#74866

@hjyamauchi hjyamauchi requested a review from a team November 21, 2024 22:05
@hjyamauchi hjyamauchi requested review from a team and removed request for a team November 22, 2024 17:45
@DougGregor DougGregor merged commit 2e61399 into swiftlang:swift/release/6.0 Dec 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants