-
Notifications
You must be signed in to change notification settings - Fork 339
Re-enable tests working on Linux #966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable tests working on Linux #966
Conversation
@adrian-prantl I don't see a reason why these two should be disabled, you? I think the only problem might be they're flakey, but we're going to figure this out soon, I believe. |
@swift-ci test |
What does |
I took a look at the history of both tests, they were set to skip Linux on 21/08/2018. Message is not very informative, just: "Merge lldb: Merge remote-tracking branch 'origin/stable' into upstream-with-swift" |
@dcci and @adrian-prantl just reminding you guys about this :) |
Can you also create the same PR for the swift/master-next branch? (just cherry-pick the changes and created a second PR, no need to re-test it) |
@adrian-prantl already did it :) #972 |
Can you please take a look at all three Linux bots on ci.swift.org tomorrow and double-check that none of the newly enabled tests are failing? It could happen that it fails on only one Ubuntu variant, and swiftci test only tests one of them. |
Ok, I'll double check tomorrow. |
This PR re-enables tests
TestSwiftConditionalBreakpoint
andTestSwiftStepping
, which are currently disabled on Linux, but pass successfully.