Skip to content

Re-enable tests working on Linux #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

augusto2112
Copy link

This PR re-enables tests TestSwiftConditionalBreakpoint and TestSwiftStepping, which are currently disabled on Linux, but pass successfully.

@dcci dcci requested review from adrian-prantl and dcci March 24, 2020 22:19
@dcci
Copy link
Member

dcci commented Mar 24, 2020

@adrian-prantl I don't see a reason why these two should be disabled, you? I think the only problem might be they're flakey, but we're going to figure this out soon, I believe.

@dcci
Copy link
Member

dcci commented Mar 24, 2020

@swift-ci test

@adrian-prantl
Copy link

What does git blame say? I suppose that stepping could be sensitive to codegen? Let's check all the various ubuntu variant bots after landing this. If they work, we'll leave them on.

@augusto2112
Copy link
Author

I took a look at the history of both tests, they were set to skip Linux on 21/08/2018. Message is not very informative, just: "Merge lldb: Merge remote-tracking branch 'origin/stable' into upstream-with-swift"

@augusto2112
Copy link
Author

@dcci and @adrian-prantl just reminding you guys about this :)

@adrian-prantl
Copy link

Can you also create the same PR for the swift/master-next branch? (just cherry-pick the changes and created a second PR, no need to re-test it)

@augusto2112
Copy link
Author

@adrian-prantl already did it :) #972

@adrian-prantl adrian-prantl merged commit 53a4923 into swiftlang:swift/master Mar 30, 2020
@adrian-prantl
Copy link

Can you please take a look at all three Linux bots on ci.swift.org tomorrow and double-check that none of the newly enabled tests are failing? It could happen that it fails on only one Ubuntu variant, and swiftci test only tests one of them.

@augusto2112
Copy link
Author

Ok, I'll double check tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants