Write log messages to files on non-Darwin platforms #1411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
hamishknight
approved these changes
Jun 4, 2024
ahoppen
changed the title
|
I re-wrote the implementation quite a bit based on feedback from @bnbarham to roll through 10 log files of 5MB each instead of truncating one log file in place since it reduces the number of bytes that need to be written (in the old implementation we needed to write 4MB every time we trimmed the start of the log). |
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
hamishknight
approved these changes
Jun 5, 2024
Comment on lines
76
to
77
| /// Occasionally check if the log file exceeds the target log size. If this is the case, truncate the beginning of the | ||
| /// log to reduce the log size. |
There was a problem hiding this comment.
I guess you could also say that the logs will be rotated if logRotateCount > 1
There was a problem hiding this comment.
Oh, this comment is just completely outdated.
Instead of logging to `stderr`, write log messages to files in `.sourcekit-lsp/logs/sourcekit-lsp-<pid>.<log index>.log`. This allows us to retrieve the log messages from `sourcekit-lsp diagnose`. Fixes swiftlang#1286 rdar://127138318
ahoppen
changed the title
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of logging to
stderr, write log messages to files in/var/log/sourcekit-lsp/sourcekit-lsp-<pid>.log.This allows us to retrieve the log messages from
sourcekit-lsp diagnose.Fixes #1286
rdar://127138318