[6.0] Add test case that we don't reload the package if a .swift file get added in a folder that doesn't affect compilation
#1512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added in a folder that doesn't affect compilation rdar://128573306
ahoppen
changed the title
.swift file get….swift file get added in a folder that doesn't affect compilation
|
swiftlang/swift-package-manager#7709 @swift-ci Please test |
|
swiftlang/swift-package-manager#7709 @swift-ci Please test |
ahoppen
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Jun 26, 2024
… from `LLBuildManifestBuilder` (#7709) - **Explanation**: Instead of inspecting file extensions to decide whether a file might affect build settings, check which files are in directories that are affecting compilation. This is the same logic that `LLBuildManifestBuilder` uses and should be more stable. In particular, this stops us from reloading the package manifest in SourceKit-LSP when a header file is written to a `.build` directory. - **Scope**: Only affects SourceKit-LSP - **Risk**: Low, only affects SourceKit-LSP - **Testing**: Adding a SourceKit-LSP test case in swiftlang/sourcekit-lsp#1512 - **Issue**: rdar://128573306 - **Reviewer**: @MaxDesiatov @xedin on #7699
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLBuildManifestBuilderuses and should be more stable. In particular, this stops us from reloading the package manifest in SourceKit-LSP when a header file is written to a.builddirectory.fileAffectsSwiftOrClangBuildSettingswith the logic fromLLBuildManifestBuilderswift-package-manager#7699