Log to stderr as well as the log file, on non-Darwin platforms #2155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
May 13, 2025
There was a problem hiding this comment.
We do log to stderr until we set up the global log file handlers using setUpGlobalLogFileHandler. We should also log to stderr from there. With the current implementation, we would log every message twice if setting up the global log file handlers failed (once from the log handler and then once again from your fputs call).
|
Gotcha, presumably something like this is better? |
This is consistent with other LSP servers, and makes debugging sourcekit-lsp easier.
|
@swift-ci please test |
bnbarham
reviewed
May 16, 2025
Comment on lines
+119
to
+122
| // In addition to writing to the log file, also log to stderr, so LSP output is visible in the editor | ||
| // (e.g. VS Code's Output panel). | ||
| fputs(message + "\n", stderr) | ||
|
|
There was a problem hiding this comment.
Almost LGTM :). But now that we're printing this to stderr as well, I think we can remove the \(message) from the fputs below when the write to the log fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with other LSP servers, and makes debugging sourcekit-lsp easier.
This was initially discussed in #2116. Let me know if you think we should log to stderr on macOS too.