Add module map for CSKTestSupport #2243
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a module map for the CSKTestSupport module, exporting the header "CSKTestSupport.h". This allows for better modularization and encapsulation of the support functionalities. Signed-off-by: Maxwell Elliott <[email protected]>
maxwellE
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
ahoppen
reviewed
Aug 14, 2025
|
My guess is bazel (?), but I'm still wondering why the modulemap is needed - nothing is importing CSKTestSupport, it's just being linked into SKTestSupport to not call static destructors. I assume the modulemap is there at all purely to appease SwiftPM. And if we do need to specify something in the module, my preference would be for it to still be empty rather than adding this header. There's no intention that anything would ever import and call this function. |
Signed-off-by: Maxwell Elliott <[email protected]>
|
This was done to support using this library via https://github.com/cgrindel/rules_swift_package_manager building with Bazel |
Signed-off-by: Maxwell Elliott <[email protected]>
ahoppen
approved these changes
Aug 15, 2025
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
3 similar comments
|
@swift-ci Please test Windows |
|
@swift-ci Please test Windows |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a module map for the CSKTestSupport module, exporting the header "CSKTestSupport.h". This allows for better modularization and encapsulation of the support functionalities.
Signed-off-by: Maxwell Elliott [email protected]
Existing SPM users appear to be not impacted, this change should not affect their builds
Some build systems cannot build this logic without this modulemap file being valid
Original PRs:
Risk:
Low
Does it build