[cmake] Remove dependency on PackageModelSyntax library #2244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to swiftlang#2235. The change removed uses of `PackageModelSyntax` but left is in `target_link_libraries` of `SourceKitLSP`.
xedin
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci please test |
bnbarham
approved these changes
Aug 14, 2025
| TSCExtensions | ||
| Crypto | ||
| TSCBasic | ||
| PackageModel |
There was a problem hiding this comment.
Do we still need PackageModel?
There was a problem hiding this comment.
Yeah, it's used in a few places. I can look into removing that as well separately!
There was a problem hiding this comment.
This is going to be addressed by #2245
ahoppen
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #2235.
The change removed uses of
PackageModelSyntaxbut left is intarget_link_librariesofSourceKitLSP.