Require macOS 10.15 #369
Merged
Require macOS 10.15 #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The same requirement is being added to SwiftPM as part of swiftlang/swift-package-manager#3202. Without this change SourceKit-LSP will fail to build with error: ``` the library 'SKSwiftPMWorkspace' requires macos 10.10, but depends on the product 'SwiftPM-auto' which requires macos 10.15; consider changing the library 'SKSwiftPMWorkspace' to require macos 10.15 or later, or the product 'SwiftPM-auto' to require macos 10.10 or earlier. ``` Modification: Require macOS 10.15. Result: SourceKit-LSP builds successfully with changeset swiftlang/swift-package-manager#3202.
|
@swift-ci please test |
benlangmuir
approved these changes
Feb 3, 2021
|
@benlangmuir Can you please merge this when ready since I don't have permissions to? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The same requirement is being added to SwiftPM as part of swiftlang/swift-package-manager#3202. Without this change SourceKit-LSP will fail to build with error:
Modification:
Require macOS 10.15.
Result:
SourceKit-LSP builds successfully with changeset
swiftlang/swift-package-manager#3202.