-
Notifications
You must be signed in to change notification settings - Fork 184
Update discussion of boxed protocol types [SE-0335] #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
amartini51
merged 31 commits into
swiftlang:main
from
amartini51:existential_any_88208011
May 26, 2023
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
54a8b5a
Start sketching reference for existential any.
amartini51 85540f1
Mention Any and AnyObject as related to 'any'.
amartini51 bb28dce
Add 'any' to code listings.
amartini51 1f8cee3
Wording & spelling fix.
amartini51 a17a3dd
Move existentials out of Protocols chapter.
amartini51 851b86d
Add forward references for "protocol as type".
amartini51 87638d7
Mark some places I need to come back to.
amartini51 5837abb
Track 'main' to resolve merge conflicts.
amartini51 4112fde
Move existentials in with opaque types.
amartini51 9c0990d
Update task marker comments.
amartini51 edd9b60
Revise outline.
amartini51 462d18a
Rough in a better example of existentials.
amartini51 859e88a
Fix markup for code voice.
amartini51 134ed8d
Add existentials to the chapter intro.
amartini51 ac1da69
Expand the code listing and its discussion.
amartini51 779b444
Add a rough note about perf impact.
amartini51 66fa9cc
Use the term "boxed protocol type" consistently.
amartini51 8f6c37e
Finish contrasting opaque & boxed types in reference.
amartini51 bbb5b19
Remove old example.
amartini51 ecbe6c5
Introduce "box" earlier and clean up phrasing.
amartini51 db4ab34
Track 'main' to resolve merge conflict.
amartini51 f7c0c81
Add an example of as-casting an existential.
amartini51 af9a709
Minor wording adjustments from review.
amartini51 212dbdf
Fix a link.
amartini51 203b915
Use proper markup for new grammar production.
amartini51 f808c8f
Fix em-dash.
amartini51 71108e5
Add boxed-protocol-type to the grammar summary.
amartini51 f40066e
Any and AnyObject are already boxed.
amartini51 1c78f5a
Remove unneeded tech review query.
amartini51 bd69a4c
Remove stray whitespace.
amartini51 4754b42
Incorporate edits.
amartini51 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.