Skip to content

Align fatalError messages in Objective-C bridging methods for consistency #5123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Align fatalError messages in Objective-C bridging methods for consistency #5123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb3c3d8
Updated fatalError message in DateComponents bridging method to refle…
nnabeyang Oct 26, 2024
a674977
Aligned fatalError message in Notification bridging method with the f…
nnabeyang Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Foundation/DateComponents.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ extension DateComponents : _ObjectiveCBridgeable {

public static func _forceBridgeFromObjectiveC(_ dateComponents: NSDateComponents, result: inout DateComponents?) {
if !_conditionallyBridgeFromObjectiveC(dateComponents, result: &result) {
fatalError("Unable to bridge \(DateComponents.self) to \(self)")
fatalError("Unable to bridge \(NSDateComponents.self) to \(self)")
}
}

Expand Down
2 changes: 1 addition & 1 deletion Sources/Foundation/Notification.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ extension Notification : _ObjectiveCBridgeable {

public static func _forceBridgeFromObjectiveC(_ x: NSNotification, result: inout Notification?) {
if !_conditionallyBridgeFromObjectiveC(x, result: &result) {
fatalError("Unable to bridge type")
fatalError("Unable to bridge \(NSNotification.self) to \(self)")
}
}

Expand Down