tests: allow passing in SDKROOT for Windows as well #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow passing through `-sdk %SDKROOT%` on Windows for tests.
|
@swift-ci please test |
briancroom
approved these changes
Oct 1, 2021
compnerd
added a commit
to compnerd/swift-build
that referenced
this pull request
Oct 1, 2021
Fix the build rules for the corelibs, build nearly a complete SDK. This is sufficient for getting test coverage for XCTest for the time being. This change requires swiftlang/swift-corelibs-xctest#332 to be merged for the tests to pass. dispatch_overcommit has long been flakey on the CI environments but does not flake on real hardware. The Foundation invalidBundlePath test is known to be currently broken after the last merge for Foundation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing through
-sdk %SDKROOT%on Windows for tests.