[5.9] build_script.py: use python3 by default
#450
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're seeing sporadic CI failures, since apparently some nodes don't have `python` symlinking to a correct Python version. Changing this to `python3` will also make it consistent with the rest of the Python scripts in the Swift project.
MaxDesiatov
changed the title
python3 by defaultpython3 by default
|
@swift-ci test |
grynspan
approved these changes
Jun 14, 2023
|
@MaxDesiatov My understanding was that this was resolved upstream in the main Swift repository by this PR: Did that fix not work, or do we need to land that PR in the Swift repo on the 5.8 and 5.9 branches? |
|
@swift-ci please test macOS platform |
|
I don't think this is necessary/appropriate for 5.9 at this point. Please let me know if that's not the case! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing sporadic CI failures, since apparently some CI nodes don't have
pythonsymlinking to a correct Python version. Changing this topython3will also make it consistent with the rest of the Python scripts in the Swift project.Risk: low, all other Python scripts in the
swiftandswift-package-managerrepositories already include this change and usepython3in bothmainandrelease/5.9branches.Original PRs: #449
Reviewed by: @grynspan
Resolves: unblocks PRs on the
swift-corelibs-foundationrepository that build XCTest as a part of their CI jobs.Tests: N/A