build: optionalise Foundation and dispatch #514
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than requiring the build tree for the dependencies, optionalise them. This allows us to build against an existing SDK or against the build tree. This flexibility allows us to change the build order when building the Windows toolchain against a SDK that is being built up. Without this change, we must provide a dispatch build tree which will inject the modulemap for the dispatch runtime which conflicts with the verison in the SDK that is being built against.
compnerd
requested review from
stmontgomery,
grynspan,
jerryjrchen and
briancroom
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than requiring the build tree for the dependencies, optionalise them. This allows us to build against an existing SDK or against the build tree. This flexibility allows us to change the build order when building the Windows toolchain against a SDK that is being built up. Without this change, we must provide a dispatch build tree which will inject the modulemap for the dispatch runtime which conflicts with the verison in the SDK that is being built against.