build: fix dependencies #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
daniel-grumberg
approved these changes
May 30, 2023
We need this to use the new initialiser `init(url:exact:)` for updating the standalone build to match the CI build. When building in CI, we would build against swift-crypto 2.5.0 as per update-checkout-config.json in apple/swift. Adjust the standalone builds to match. When building on CI, we would build against swift-argument-parser 1.2.2 as per update-checkout-config.json in apple/swift. Make the standalone builds match.
…NIO). - Remove deprecated usages and bump the dependency version requirements for NIO, ArgumentParser, and SwiftCrypto (most especially the latter so that updates in the 2.x series are available). - Remove old #if swift conditionals no longer required - Package.resolved now uses the version 2 format
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use updated
Package.swiftmanifest syntax for updating the standalone build to better match the CI build.When building in CI, we build against
swift-crypto2.5.0 as perupdate-checkout-config.jsonin apple/swift. Adjust the standalone builds to match.When building on CI, we would build against
swift-argument-parser1.2.2 as perupdate-checkout-config.jsonin apple/swift. Make the standalone builds match.We build against versions of NIO which have a minimum Swift version requirement of 5.6. Match that requirement and update the manifest syntax to match.