Remove API that was deprecated during the 5.9 release #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release after 5.10 is not 5.11 but 6.0. The API said 5.12 in their deprecation message was really deprecated during the 5.10 release and should have said 5.11 as the version the API will be removed.
patshaughnessy
approved these changes
Mar 18, 2024
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable:
Summary
Now that version 5.10 is released, API that's been deprecated during the 5.9 release can be removed according to the process described in the "Introducing source breaking changes" section of CONTRIBUTING.md.
The plan is to not cherry-pick this into the 6.0 release branch, so in practice we kept this API around for longer than what the deprecation message communicated.
This also updates the deprecation message for API that said that it would be removed after "5.11" is release to instead say that it will be removed after "6.0" is released now that we know that there is no 5.11 version (6.0 is the version after 5.10).
Some API was incorrectly annotated to say that it will be removed after 5.12 is released. This API was deprecated during the 5.10 release, meaning that our guideline would be to remove it after 6.0 (what was known as 5.11) is released. These have also been updated to "6.0".
Dependencies
None.
Testing
Nothing in particular. DocC itself wasn't using this API anymore.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
[ ] Added tests./bin/testscript and it succeeded[ ] Updated documentation if necessary