Windows: introduce a new docker image for Windows #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
4 tasks
tristanlabelle
approved these changes
Dec 20, 2023
| Remove-Item -Force python-3.9.13-amd64.exe; \ | ||
| Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\* | ||
|
|
||
| # Install Visual Studio Build Tools |
There was a problem hiding this comment.
You could point to https://visualstudio.microsoft.com/license-terms/vs2022-ga-diagnosticbuildtools/ to clarify that the license allows usage for open-source projects.
There was a problem hiding this comment.
AIUI, it is also permitted for closed-source usage in the case that you have a Visual Studio license. I can certainly add it, but I do not know if it adds value to the docker image construction. I think it might be better suited as README content if we wanted to include that.
Introduce a docker image that is meant for CI purposes. This is a complete docker image that should have the necessary components for building a Windows toolchain with some `subst` trickery.
compnerd
force-pushed
the
development
branch
from
ef245b3 to
b455681
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a docker image that is meant for CI purposes. This is a complete docker image that should have the necessary components for building a Windows toolchain with some
substtrickery.