Skip to content

Revert "[Planning] Avoid batching compile job twice" #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

owenv
Copy link
Contributor

@owenv owenv commented Mar 3, 2025

This reverts commit 7ba9d48.

This is breaking swift-build CI, because SwiftDriver now fails to return a build plan to clients when there are 0 mandatory jobs

@owenv owenv requested review from artemcm and cachemeifyoucan March 3, 2025 18:01
@owenv
Copy link
Contributor Author

owenv commented Mar 3, 2025

@swift-ci test

@owenv
Copy link
Contributor Author

owenv commented Mar 3, 2025

This reverts one commit from #1825, but leaves the other 2

@owenv owenv enabled auto-merge March 3, 2025 18:09
@owenv owenv merged commit a9afe15 into main Mar 3, 2025
3 checks passed
@cachemeifyoucan
Copy link
Contributor

@owenv I will take a look. Maybe we should get swift-driver bot to run swift-build test suite as well just to increase coverage? The swift-driver bot is currently very fast so I won't mind it test more (for Mac and Linux for now, before windows is switched to the new system).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants