Expose BuildRecordInfo.computeHash
#1922
Merged
+13
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwiftPM will compute a hash of the arguments passed to `swift build`, `swift test`, etc to determine if a full rebuild is necessary. Currently, it doesn't take in to account whether `.doesNotAffectIncrementalBuild` is set on swift compiler options and so any time any compiler option changes it will perform a full rebuild. Expose the function that swift-driver uses to compute the argument hash which takes in to account `.doesNotAffectIncrementalBuild` so that SwiftPM can leverage it to reduce unnecessary rebuilds. In order to keep `BuildRecordInfo` hidden behind `_spi` the function was moved out to the standalone `BuildRecordArguments` struct.
|
@swift-ci please test |
artemcm
approved these changes
Jun 10, 2025
|
@swift-ci please test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwiftPM will compute a hash of the arguments passed to
swift build,swift test, etc to determine if a full rebuild is necessary. Currently, it doesn't take in to account whether.doesNotAffectIncrementalBuildis set on swift compiler options and so any time any compiler option changes it will perform a full rebuild.Expose the function that swift-driver uses to compute the argument hash which takes in to account
.doesNotAffectIncrementalBuildso that SwiftPM can leverage it to reduce unnecessary rebuilds.In order to keep
BuildRecordInfohidden behind_spithe function was moved out to the standaloneBuildRecordArgumentsstruct.