Cleanup to prepare for emit-module-separately by default #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With emit-module-separately by default the compiler no longer use compile jobs for -emit-module.
The linker uses the swiftmodule file generated by the emit-module job.
…eduled This prevents generating duplicate files and feeding duplicated diagnostics to Xcode.
|
@swift-ci Please test |
artemcm
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts fixes and test updates from #730 as these are safer and less likely to be reverted. A few tests are hardened, some explicitly use merge-modules and others are preemptively moving to emit-module-separately.