Ensure that SimpleDateFormat::fUsePlainSpaces is always initialized #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCharlesHu
approved these changes
Jul 31, 2024
glessard
approved these changes
Jul 31, 2024
iCharlesHu
added a commit
to iCharlesHu/swift-foundation-icu
that referenced
this pull request
Aug 1, 2024
jmschonfeld
force-pushed
the
date-format-uninitialized
branch
from
bf243d9 to
b05b241
Compare
|
Linux and Windows toolchain tests pass with this change |
jmschonfeld
added a commit
to jmschonfeld/swift-foundation-icu
that referenced
this pull request
Aug 1, 2024
jmschonfeld
added a commit
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bug in our implementation that would leave
SimpleDateFormat::fUsePlainSpacesuninitialized on non-Darwin. This would mean that when we read the uninitialized memory, the nondeterministic contents would determine whether date format patterns used U+0020 or U+202F leading to sporadic test failures that didn't account for both variants. This ensures the variable is always initialized to false so that we always get U+202F.This should allow us to remove hacks like https://github.com/apple/swift-foundation/blob/8a44479120e4ae0ac8cdbf801943daa0d1e874ad/Sources/TestSupport/TestSupport.swift#L246-L274 entirely since we now use a deterministic separator.