Convert Data/DataIO Tests to swift-testing #1363
Conversation
jmschonfeld
force-pushed
the
swift-testing/data-tests
branch
2 times, most recently
from
b0c0bca to
d121864
Compare
| @@ -893,6 +901,47 @@ private struct StringTests { | |||
| #expect(result == expected) | |||
| } | |||
| } | |||
|
|
|||
| @Test func deletingLastPathComponent() { | |||
There was a problem hiding this comment.
Thanks for consolidating these!
| isEmpty = span.isEmpty | ||
| #expect(!isEmpty) | ||
| count = span.count | ||
| #expect(count == count) |
There was a problem hiding this comment.
Maybe a different variable name (or source.count) would be good :)
There was a problem hiding this comment.
Oh good call, thanks this is probably a typo on my part 🙂 - likely a find and replace error while extracting the span calls out of the expectations (which sadly don't work because #expect can't capture the non escapable type in its escaping closure)
There was a problem hiding this comment.
It turns out that span.count in an expectation is fine, so I removed the extra variables. span.isEmpty doesn't work, so I've left the isEmpty variables and filed swiftlang/swift-testing#1164 about the discrepancy
jmschonfeld
force-pushed
the
swift-testing/data-tests
branch
from
d121864 to
2dede55
Compare
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
Continued cherry-picks (with edits) of the initial swift-testing adoption for all of our data-related tests