rdar://131793235 (Invalid JSON string causes precondition failure) #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
parkera
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very large number values, like 100e200 are technically valid JSON, and so are not flagged by the parsing layer as invalid. When decoded as a Decimal, which cannot hold this value, we need a signal that differentiates that the value is too large compared to the input being unparseable. This allows JSONDecoder to throw the correct kind of error instead of hitting a fatal error.
This also generalizes the parsing implementation on Collection<UTF8.CodeUnit> so that JSONDecoder doesn't have to instantiate a throw-away String.