Adding some more tests for [U]Int128 in BinaryInteger+FormatStyleTests.swift and JSONEncoderTests.swift #806
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update minimum OS version for Int128 in testTypeCoercion()
Add more Int128 test for testTypeCoercion()
Add more test case Int128 for for testTypeCoercion()
Add more test case UInt128 for for testTypeCoercion()
|
Dear @parkera , I have a minor update for [U]Int128 in JSONEncoderTests. Could you help me to review it? and some wording typo. Thanks, |
Correct typo comment from "resovled" to "resolved" at URL.swift
Adding more case to testing [U]Int128
Adding more case to testing [U]Int128
Replace "@available" with "#available".
Replace "@available" with "#available".
|
Dear @stephentyrone , @kperryua , Could you please help me to reivew my PR? Thanks, |
stephentyrone
approved these changes
Aug 1, 2024
|
@swift-ci test |
|
Dear @stephentyrone , Thank you for your review. Could you help me to merge it? I do not have "write access" permission. Thanks, |
|
Would you mind updating the title to something a bit more descriptive of the change? It looks like this is about adding availability for some of the new tests. |
lamtrinhdev
changed the title
|
Dear @parkera , Thank you for your feedback. I just updated the title. Please help me to review it. Thanks, |
parkera
approved these changes
Aug 2, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
[U]Int128support forJSONEncoderTeststestTypeCoercionintestTypeCoercion()[U]Int128intestNumericStringRepresentation_builtinIntegersLimits()resovledtoresolvedatURL.swiftModifications: