Skip to content

Conversation

jmschonfeld
Copy link
Contributor

When FoundationMacros was moved into its own CMake project, we did not copy over the SWIFT_SYSTEM_NAME setting. This results in the rpath for libFoundationMacros.so being $ORIGIN/../../../swift/:$ORIGIN/.. instead of the correct value ($ORIGIN/../../../swift/linux:$ORIGIN/.. for linux, for example). This fixes the macro build which allows #Predicate and #Expression to work as expected.

(note for context that this set value is used on line 90 of this file: INSTALL_RPATH "$ORIGIN/../../../swift/${SWIFT_SYSTEM_NAME}:$ORIGIN/..")

Unverified

The signing certificate or its chain could not be verified.
@jmschonfeld
Copy link
Contributor Author

@swift-ci please test

@jmschonfeld jmschonfeld merged commit ef8c1d5 into swiftlang:main Sep 3, 2024
@jmschonfeld jmschonfeld deleted the fix-macro-rpath branch September 3, 2024 21:58
jmschonfeld added a commit to jmschonfeld/swift-foundation that referenced this pull request Sep 3, 2024

Unverified

The signing certificate or its chain could not be verified.
jmschonfeld added a commit that referenced this pull request Sep 4, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
jmschonfeld added a commit to jmschonfeld/swift-foundation that referenced this pull request Sep 4, 2024

Unverified

The signing certificate or its chain could not be verified.
jmschonfeld added a commit to jmschonfeld/swift-foundation that referenced this pull request Sep 5, 2024

Unverified

The signing certificate or its chain could not be verified.
jmschonfeld added a commit that referenced this pull request Sep 5, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
cthielen pushed a commit to cthielen/swift-foundation that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

None yet

2 participants