Expect XCTest.lib in arch-disambiguated directory in the Windows installer #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristanlabelle
requested review from
shahmishal,
tomerd and
compnerd
as code owners
|
I'm not sure how this worked previously, but ... okay. |
|
It wouldn't have worked if building for two different architectures and then the msi's for those two architectures (they would both have picked up the latter lib file), but it would have worked if building one architecture, its msi, then the other architecture, and then its msi. |
|
I think that we staged to different directories, I just don't understand how I never ran into any issues yet 🤯 |
|
Abandonning in favor of handling this in the build scripts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Windows installer to account for swiftlang/swift-corelibs-xctest#434