Skip to content

WiX: simplify the swift-format package definition #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2023

Conversation

compnerd
Copy link
Member

  • Use durable GUID generation for auto-generation of the GUID.
  • Combine the platform definitions into a singular source to avoid drift.

This avoids having to keep the variants in sync and provides an easier upgrade path. This is the first step towards enabling a non-admin experience for users.

- Use durable GUID generation for auto-generation of the GUID.
- Combine the platform definitions into a singular source to avoid
  drift.

This avoids having to keep the variants in sync and provides an easier
upgrade path.  This is the first step towards enabling a non-admin
experience for users.
@compnerd compnerd requested a review from etcwilde May 27, 2023 18:25
Copy link
Contributor

@tristanlabelle tristanlabelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

install seems to work with swiftc. Can't really test the swift-format tool since it's not included in the build, so this control path wasn't really doing anything at the moment anyway.

@compnerd compnerd merged commit 33f517a into swiftlang:main May 30, 2023
@compnerd compnerd deleted the format-format branch May 30, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants