WiX: correct the install conditions #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a surprising interaction between variable types. Variables set at the command line are set as string types. The variables in the bundle are numeric (either `1` or `0` to match the semantics of check boxes). The original install condition (`InstallCondition="OptionsInstall.*"` would evaluate the condition as a string, where _any_ value would evaluate as `true`. To force a comparison, where Burn will coerce values more like expectations, perform an explicit equality check.
|
Tested at https://ci-external.swift.org/job/swift-PR-build-toolchain-windows/5422/ ; ran the installer locally and verified that |
hyp
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a surprising interaction between variable types. Variables set at the command line are set as string types. The variables in the bundle are numeric (either
1or0to match the semantics of check boxes). The original install condition(
InstallCondition="OptionsInstall.*"would evaluate the condition as a string, where any value would evaluate astrue. To force a comparison, where Burn will coerce values more like expectations, perform an explicit equality check.