Skip to content

Conversation

bnbarham
Copy link
Contributor

Rather than the one-off hack in test-sourcekit-lsp.py, just set the IO encoding to UTF8 for all tests.

Rather than the one-off hack in `test-sourcekit-lsp.py`, just set the
IO encoding to UTF8 for all tests.
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham
Copy link
Contributor Author

Toolchain build passed in the linked PR.

Copy link
Member

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@bnbarham bnbarham merged commit 7d6bf13 into swiftlang:main Sep 7, 2023
@bnbarham bnbarham deleted the set-python-encoding branch September 7, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants