Skip to content

Verify wasmkit is a universal binary #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025
Merged

Verify wasmkit is a universal binary #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4aa862
In lit.cfg, add wasmkit_path and substitution; check that path exists
wti Jun 23, 2025
23009aa
New test-universal-darwin.py verifies wasmkit executable is universal
wti Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lit.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,11 @@ docc_path = lit_config.params.get(
os.path.join(package_path, "usr", "bin", "docc"))
lit_config.note("testing using 'docc': {}".format(docc_path))

wasmkit_path = lit_config.params.get(
"wasmkit",
os.path.join(package_path, "usr", "bin", "wasmkit"))
lit_config.note("testing using 'wasmkit': {}".format(wasmkit_path))

# Verify they exist.
if not os.path.exists(swift_path):
lit_config.fatal("swift does not exist!")
Expand All @@ -231,6 +236,8 @@ else:

if not os.path.exists(docc_path):
lit_config.fatal("docc does not exist!")
if not os.path.exists(wasmkit_path):
lit_config.fatal("wasmkit does not exist!")

# Define our supported substitutions.
config.substitutions.append( ('%{package_path}', package_path) )
Expand All @@ -246,6 +253,7 @@ config.substitutions.append( ('%{readelf}', readelf_path) )
config.substitutions.append( ('%{readobj}', readobj_path) )
config.substitutions.append( ('%{sourcekit-lsp}', sourcekit_lsp_path) )
config.substitutions.append( ('%{docc}', docc_path) )
config.substitutions.append( ('%{wasmkit}', wasmkit_path) )

# Add substitutions for swiftpm executables.
swiftpm_build = lit_config.params.get("swiftpm-build")
Expand Down
7 changes: 7 additions & 0 deletions test-snapshot-binaries/test-universal-darwin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Tests that executables are universal binaries on MacOS
# REQUIRES: platform=Darwin
#
# RUN: file %{wasmkit} | %{FileCheck} --check-prefix CHECK-WASMKIT %s
# CHECK-WASMKIT: {{.*}} Mach-O universal binary {{.*}}
#