use older if let syntax in Link.isAutolink
#112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://106666684
|
@swift-ci Please test |
d-ronnqvist
approved these changes
Mar 13, 2023
Kyle-Ye
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://106666684
Summary
The
Link.isAutolinkproperty added in #110 used the newerif let bindingsyntax added in Swift 5.8. However, PR testing in Swift-DocC is done with Swift 5.5, causing the PR test to fail. This PR "downgrades" the syntax in theisAutolinkproperty getter to ensure compatibility with Swift 5.5.Dependencies
None
Testing
Ensure this branch builds with Swift 5.5, for example using the
swift:5.5-focalDocker image.Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded