Skip to content

Update to GitHub profiles #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2023

Conversation

dempseyatgithub
Copy link
Contributor

@dempseyatgithub dempseyatgithub commented Sep 21, 2023

This change is a follow-on to PR #408.

Twitter/X now requires being logged-in to view profile information. GitHub displays profile information without being logged-in.

To provide a more consistent user experience when clicking on the linked profile of an author in a byline or person mentioned in a post, this PR:

  • Adds the appropriate GitHub profile name for the three authors with that info missing
  • Replaces links to Twitter profiles to the corresponding GitHub profile in the body of blog posts.

Corresponding GitHub profiles were verified manually to ensure the correct profile was used.

Note that after merging this PR, twitter.com is linked to only for the Swift project’s SwiftLang account, and in blog posts where specific posts are linked to on Twitter.

Copy link
Member

@alexandersandberg alexandersandberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dempseyatgithub
Copy link
Contributor Author

@swift-ci test

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomerd tomerd merged commit 6976992 into swiftlang:main Oct 1, 2023
@dempseyatgithub dempseyatgithub deleted the update-to-github-profiles branch October 1, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants