[Issue #5923] Fix resource-related build failure for package containing Objective-C and C sources

[ncooke3]

Fix issue where adding a resource to a package containing Objective-C and C sources causes a build failure. Note: This only occurs when using swift build via the package manager CLI.

Motivation:

Please see #5923 for the context regarding the issue. The package manager will add the resource_bundle_accessor.h as an input when compiling C sources. This causes a build failure because of the Foundation import in resource_bundle_accessor.h.

This PR fixes this issue.

Modifications:

• Modify build instructions for Clang targets to not include the -include /path/to/resource_bundle_accessor.h compile argument when compiling a C source.
• Add unit test testClangBundleAccessor in BuildPlanTests.swift. I wrote this with intention of testing the fix but it doesn't actually test anything because those tests don't actually build anything. I was going to delete it, but noticed that resource bundle generation in Clang targets hasn't been tested so maybe it's a good test to keep?
• Add unit test testResourcesInMixedClangPackage in TestToolTests.swift to test this fix and potential regressions.
• Add corresponding fixture target for unit testing this fix.

Result:

This fix enables packages to contain mixed Clang sources (e.g. Objective-C and C) and resources.

Fixes #5923.

[MaxDesiatov]

@swift-ci please smoke test

[MaxDesiatov]

According to build logs, BuildPlanTests.testClangBundleAccessor fails in certain scenarios on both macOS and Linux.

[ncooke3]

According to build logs, BuildPlanTests.testClangBundleAccessor fails in certain scenarios on both macOS and Linux.

@MaxDesiatov, could you share any relevant info from the build logs? I get a 403 forbidden when trying to see the CI failures myself.

I could just remove the test since it's not directly related to this PR's change, but think it'd be nice to have if I can get it working.

[MaxDesiatov]

@ncooke3 ci.swift.org is up after some downtime, can you see the logs now?

[ncooke3]

@ncooke3 ci.swift.org is up after some downtime, can you see the logs now?

yep– now I can. Will take a look...

[ncooke3]

Hi @MaxDesiatov, could you kick off CI again?

[MaxDesiatov]

@swift-ci please smoke test

[ncooke3]

In one of the tests I added, the order of two arrays I'm comparing seems to be non-deterministic. My latest commit should fix the CI failure by sorting both before comparing. Please kick off another round of CI.

[neonichu]

@swift-ci please smoke test

[neonichu]

@swift-ci please smoke test

[neonichu]

@swift-ci please smoke test