update plugin argument parsing so that execution arguments can be passed after command plugin name #6128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
neonichu
reviewed
Feb 7, 2023
|
With #6114, we have one more plugin option now. |
tomerd
force-pushed
the
fix/plugin-argument
branch
from
212993e to
93008f9
Compare
natecook1000
reviewed
Feb 8, 2023
| // At this point we know we found exactly one command plugin, so we run it. | ||
| try PluginCommand.run( | ||
| plugin: matchingPlugins[0], | ||
| package: packageGraph.rootPackages[0], | ||
| packageGraph: packageGraph, | ||
| options: pluginOptions, | ||
| arguments: Array( remaining.dropFirst()), | ||
| swiftTool: swiftTool) | ||
| arguments: pluginArguments.remaining, |
There was a problem hiding this comment.
I think you want to keep passing the same Array(remaining.dropFirst()) arguments to the plugin, since the new approach is going to strip out anything that matches a swift package flag or option. Like --verbose could get eaten up during the re-parsing even if it has been making its way to the plugin.
…sed after command plugin name motivaiton: improve usability of command plugins changes: * re-parse the arguments that are passed after the plugin name and merge the relevant options before running the command plugin
tomerd
force-pushed
the
fix/plugin-argument
branch
from
93008f9 to
309345d
Compare
|
@swift-ci smoke test |
|
@neonichu @natecook1000 this should be ready |
neonichu
reviewed
Feb 9, 2023
| // List the available plugins, if asked to. | ||
| if listCommands { | ||
| let packageGraph = try swiftTool.loadPackageGraph() |
neonichu
approved these changes
Feb 9, 2023
tomerd
force-pushed
the
fix/plugin-argument
branch
from
309345d to
0c65684
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: improve usability of command plugins
changes: re-parse the arguments that are passed after the plugin name and merge the relevant options before running the command plugin
this allows invocation like
swift package <plugin> --disable-sandbox(instead of the lest intuitiveswift package --disable-sandbox <plugin>