Tests: adjust the BuildPlanTests for Windows #6682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested review from
abertelrud,
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci please smoke test |
compnerd
force-pushed
the
planning-build-plans
branch
from
6648670 to
76942a6
Compare
compnerd
changed the title
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
tomerd
reviewed
Jul 10, 2023
compnerd
force-pushed
the
planning-build-plans
branch
from
76942a6 to
4a50ede
Compare
|
@swift-ci please smoke test |
compnerd
force-pushed
the
planning-build-plans
branch
from
4a50ede to
132e306
Compare
|
@swift-ci please smoke test |
tomerd
approved these changes
Jul 11, 2023
|
@swift-ci please test Windows platform |
MaxDesiatov
reviewed
Jul 11, 2023
compnerd
force-pushed
the
planning-build-plans
branch
from
132e306 to
f6e32d1
Compare
|
@swift-ci please smoke test |
MaxDesiatov
reviewed
Aug 17, 2023
compnerd
force-pushed
the
planning-build-plans
branch
from
f6e32d1 to
0209644
Compare
|
@swift-ci please smoke test |
The Windows toolchain does not find the default linker by default as that requires the sourcing of Visual Studio's scripts to setup the environment. Adjust the tests to explicitly specify the linker to ensure that the toolchain is usable on Windows without constraint on the environment. While in the area, adjust the expectations to account for platform path spellings. This allows us to pass these tests on Windows now. Adjust the path representation to account for Windows to allow the matching to succeed.
MaxDesiatov
approved these changes
Aug 17, 2023
compnerd
force-pushed
the
planning-build-plans
branch
from
0209644 to
8228314
Compare
|
@swift-ci please smoke test |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows toolchain does not find the default linker by default as
that requires the sourcing of Visual Studio's scripts to setup the
environment. Adjust the tests to explicitly specify the linker to
ensure that the toolchain is usable on Windows without constraint on the
environment. While in the area, adjust the expectations to account for
platform path spellings. This allows us to pass these tests on Windows
now.
Adjust the path representation to account for Windows to allow the
matching to succeed.