[5.9] Write link file list as a build command #6704
Conversation
|
Draft because this is introducing test failures that need to be investigated. |
|
@swift-ci please smoke test |
|
Test failures on CI match what I was seeing locally. |
|
I think that we should consider the |
I think we can consider that once we're able to land this. There are a number of more critical bug fixes that I need to get into 5.9 before I can return to this cherry-pick. In case you (or anyone else) has cycles to look into the failures on this PR that would increase the chances of being able to get this into 5.9. |
This moves the generation of link file lists into the build system instead of doing it ad-hoc outside of the build. For this, we have a new `WriteAuxiliaryFile` tool and associated command that should be usable for any kind of writing of auxiliary files during the build. Note that this change opted to not touch the existing infrastructure for in-process tools, so any inputs that are needed for the file generation will need to be flattened into a generic array of input nodes. The different types of file generation are keyed off a virtual node at the start of that array. (cherry picked from commit ee7f064)
neonichu
force-pushed
the
write-file-list-as-build-command-5.9
branch
from
475e69c to
ca781f6
Compare
|
Rebased the branch, but haven't been able to figure out yet what causes the test failures exactly. It seems like in some tests we're not evaluating plugins correctly anymore, but I don't know why. Separately, we also need to figure out what to do about #6755 |
|
Going to close this, at this point it is too late to confidently get this into 5.9 |
This moves the generation of link file lists into the build system instead of doing it ad-hoc outside of the build. For this, we have a new
WriteAuxiliaryFiletool and associated command that should be usable for any kind of writing of auxiliary files during the build.Note that this change opted to not touch the existing infrastructure for in-process tools, so any inputs that are needed for the file generation will need to be flattened into a generic array of input nodes. The different types of file generation are keyed off a virtual node at the start of that array.
(cherry picked from commit ee7f064)