build: convert package manifest libraries to static #6817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
added a commit
to compnerd/swift-installer-scripts
that referenced
this pull request
Aug 16, 2023
Adjust the packaging rules to remove the shared library to support migrating to static library forms for this. This should avoid the need to adjust the path when executing the compiled manifest.
|
@compnerd is this still relevant? |
|
Yeah, I think that we still want to do this - it avoids the need to alter the path and simplifies trying to debug certain things. |
compnerd
force-pushed
the
static-cast
branch
from
295b23e to
296d44c
Compare
|
@swift-ci please test |
Change `PackageDescription`, `CompilerPluginSupport`, and `PackagePlugin` to static which will enable SPM to avoid having to deal with `Path` alteration to execute the manifest on Windows. This also means that we no longer have to worry about the `DT_RUNPATH`/`LC_RPATH` on Linux and Darwin respectively.
compnerd
force-pushed
the
static-cast
branch
from
296d44c to
ec8c989
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
PackageDescriptionto static which will enable SPM to avoid having to deal withPathalteration to execute the manifest on Windows. This also means that we no longer have to worry about theDT_RUNPATH/LC_RPATHon Linux and Darwin respectively.Partially correct
CompilerPluginSupportto build statically and no longer install. This is meant to be statically incorporated intoPackageDescriptionwhich currently is not performed. This still raises the issue of public API surface as the static module is not visible externally (i.e. is not re-exported).