[5.9.0] Remove <toolchain>/usr/bin/../lib/ from directories passed to linker to look up libraries for target triple #6844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to look up libraries for target triple (swiftlang#6824) Also, update my github username in the mailmap. Resolves swiftlang#6767
finagolfin
requested review from
abertelrud,
neonichu and
tomerd
as code owners
|
Wondering what the impact would be if we only got this change in the non-macOS 5.9.0 toolchains, it may be too late for the macOS one at this point. cc @tomerd |
|
No impact, I just figured we should clean this up for 5.9.0 also, but if it's too late for that, getting it into 5.9.1 should be fine. |
|
I think main + 5.9 branch is sufficient to mitigate any risk (give it some baking time). iow, probably not merge into 5.9.0 unless there is a super compelling reason to take the risk |
|
Sounds good, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of #6824
Explanation: This host-specific toolchain directory was added years ago in #2035 to the list of library directories, but it can cause problems when cross-compiling.
Scope: Right now, nothing is placed in this directory, so remove it before it can cause problems.
Issue: #6767
Risk: low, as nothing relies on it yet
Testing: Passed all CI and I've removed it for my native Android builds of the toolchain for the last four months, without a problem.
Reviewer: @neonichu