cache DriverSupport capabilities across targets #7057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
force-pushed
the
cache-driver-capabilities
branch
2 times, most recently
from
c0ac167 to
b821567
Compare
|
@swift-ci test |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
motivation: DriverSupport capabilities require shelling, which was called for every target, while it can be cached across them motivation: * reuse DriverSupport across targets * plumb DriverSupport from SwiftTool all the way to the build system
tomerd
force-pushed
the
cache-driver-capabilities
branch
from
02e2422 to
05d909e
Compare
|
@swift-ci test |
tomerd
commented
Nov 7, 2023
| public class DriverSupport { | ||
| private var flagsMap = ThreadSafeBox<[String: Set<String>]>() | ||
| public init() {} | ||
|
|
There was a problem hiding this comment.
this is the key change, it basically means the information is cached foe the entire process which IMO is the desired effect
|
@swift-ci test |
MaxDesiatov
approved these changes
Nov 8, 2023
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: DriverSupport capabilities require shelling, which was called for every target, while it can be cached across them
changes: make DriverSupport a static util