Enable index store based on Clang feature detection #7287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Not really sure if we should land this in the current form, it does make builds on macOS slightly slower for no good reason (since we're always doing the feature detection through shelling out to clang). I see two paths forward:
|
MaxDesiatov
approved these changes
Jan 23, 2024
neonichu
force-pushed
the
index-store-based-on-clang
branch
from
cdd1629 to
687b615
Compare
|
@swift-ci please test |
|
@swift-ci please test windows |
bnbarham
reviewed
Feb 2, 2024
Sources/Basics/Collections/RandomAccessCollection+Extensions.swift
Outdated
Show resolved
Hide resolved
Sources/Build/BuildDescription/ClangTargetBuildDescription.swift
Outdated
Show resolved
Hide resolved
neonichu
force-pushed
the
index-store-based-on-clang
branch
2 times, most recently
from
9177b8f to
3567d6a
Compare
Not right now, do you should think that should be possible? |
|
@swift-ci please test |
|
@swift-ci please test windows |
1 similar comment
|
@swift-ci please test windows |
|
@swift-ci please test macOS |
Yes. There's likely an issue for it... somewhere. |
|
Actually, we do have |
neonichu
force-pushed
the
index-store-based-on-clang
branch
from
3567d6a to
1ed277c
Compare
Today, the index store is only enabled on Darwin by default and needs a manual opt-in on other platforms. We can instead switch this to enabling it based on whether the used clang supports `-index-store-path`. rdar://117744039
neonichu
force-pushed
the
index-store-based-on-clang
branch
from
1ed277c to
913ed0d
Compare
|
@swift-ci please test |
|
@swift-ci please test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, the index store is only enabled on Darwin by default and needs a manual opt-in on other platforms. We can instead switch this to enabling it based on whether the used clang supports
-index-store-path.rdar://117744039