Skip to content

Only export required SwiftSyntax targets #7489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Apr 23, 2024

Also, use SPMSwiftSyntax:: namespace to avoid potential name conflict issues.

Also, use 'SPMSwiftSyntax::' namespace to avoid potential name conflict
issues.
@rintaro
Copy link
Member Author

rintaro commented Apr 23, 2024

@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented Apr 23, 2024

swiftlang/swift-syntax#2618 failed because it's adding another dependency _SwiftSyntaxCShim to SwiftCompilerPluginMessageHandling target, but _SwiftSyntaxCShim is not listed here.

Instead of adding _SwiftSyntaxCShim to the export list, remove unnecessary items from the list because it's not needed at all.

@rintaro
Copy link
Member Author

rintaro commented Apr 23, 2024

@swift-ci Please test macOS

@rintaro
Copy link
Member Author

rintaro commented Apr 23, 2024

@swift-ci Please test Windows

@rintaro
Copy link
Member Author

rintaro commented Apr 24, 2024

swiftlang/swift-syntax#2620
@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented Apr 24, 2024

@swift-ci Please test

@rintaro rintaro enabled auto-merge (squash) April 24, 2024 04:17
@rintaro rintaro merged commit 4f83c6d into swiftlang:main Apr 24, 2024
5 checks passed
DougGregor pushed a commit to DougGregor/swift-package-manager that referenced this pull request Apr 25, 2024
Also, use `SPMSwiftSyntax::` namespace to avoid potential name conflict
issues.

(cherry picked from commit 4f83c6d)
furby-tm pushed a commit to wabiverse/swift-package-manager that referenced this pull request May 15, 2024
Also, use `SPMSwiftSyntax::` namespace to avoid potential name conflict
issues.
furby-tm pushed a commit to wabiverse/swift-package-manager that referenced this pull request May 15, 2024
Also, use `SPMSwiftSyntax::` namespace to avoid potential name conflict
issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants