Skip to content

[Build] Fix up the cmake build after swift-syntax was added #7502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bnbarham
Copy link
Contributor

Doesn't FetchContent when it isn't available right now, but we don't fetch any of the other required dependencies either. Can fix that when we fix them all.

@bnbarham
Copy link
Contributor Author

swiftlang/swift#73267

@swift-ci please test

Doesn't FetchContent when it isn't available right now, but we don't
fetch any of the other required dependencies either. Can fix that when
we fix them all.
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely looks simpler

@bnbarham
Copy link
Contributor Author

swiftlang/swift#73267

@swift-ci please test

@bnbarham
Copy link
Contributor Author

I forgot we bootstrap with CMake even outside of Windows :(

@bnbarham bnbarham closed this Apr 26, 2024
@bnbarham bnbarham deleted the windows-build branch April 26, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants