Test: Guard a ManifestSourceGenerationTest and annotate skip message #8582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
bkhouri
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
cmcgee1024 and
daveyc123
as code owners
bkhouri
force-pushed
the
t/main/augment_tets
branch
from
c82728d to
9392ce4
Compare
|
@swift-ci test |
|
@swift-ci test windows |
bkhouri
force-pushed
the
t/main/augment_tets
branch
2 times, most recently
from
21ce9e0 to
4fe04db
Compare
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test self hosted windows |
Guard a test in ManifestSourceGenerationTest based on the compiler version, and annotate skipped tests with a GitHub issue. Also, enable the two Workspace Traits tests that were added after swiftlang#8569 was merged. Relates to: swiftlang#8433 Issue: rdar://148248105
jakepetroules
approved these changes
May 2, 2025
bkhouri
force-pushed
the
t/main/augment_tets
branch
from
4fe04db to
e6fc21b
Compare
|
@swift-ci test |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guard a test in ManifestSourceGenerationTest based on the compiler version, and annotate skipped tests with a GitHub issue.
Also, enable the two Workspace Traits tests that were added after #8569 was merged.
Relates to: #8433
Issue: rdar://148248105