fix linker flags for dynamic libraries when executing command plugin #9091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supersonicbyte
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
owenv
approved these changes
Sep 5, 2025
ofc! |
|
@owenv added, can you run the CI please? |
|
@swift-ci test |
owenv
reviewed
Sep 5, 2025
| @@ -6948,5 +6948,172 @@ struct PackageCommandTests { | |||
| expectNoDiagnostics(observability.diagnostics) | |||
| } | |||
| } | |||
|
|
|||
| @Test(arguments: getBuildData(for: SupportedBuildSystemOnAllPlatforms)) | |||
There was a problem hiding this comment.
It's ok to wrap this in something like this for now to get to a passing CI run:
withKnownIssue {
} when: {
ProcessInfo.hostOperatingSystem == .windows
|| (ProcessInfo.hostOperatingSystem == .linux && data.buildSystem == .swiftbuild)
}
There are some unrelated issues setting up the runtime library paths on linux for plugin executables which I haven't fixed yet.
There was a problem hiding this comment.
@owenv can you rerun the CI again, please?
jakepetroules
approved these changes
Sep 6, 2025
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add appropriate
-toolsuffix to linker flags in dynamic libraries when executingswift package command_plugin.Motivation:
Resolves the following issue: #9062
Modifications:
Add appropriate
-toolsuffix to linker flags in dynamic libraries when executingswift package command_plugin.Result:
Executing
swift package command_pluginwith dynamic dependencies works.