Skip to content

workflows: Run unit tests using GitHub Actions #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 10, 2025
Merged

workflows: Run unit tests using GitHub Actions #200

merged 3 commits into from
Mar 10, 2025

Conversation

euanh
Copy link
Contributor

@euanh euanh commented Mar 10, 2025 •
edited
Loading

This PR re-enables the test job which was commented out in #199.

  • Windows support depends on Swift NIO
  • End-to-End tests are disabled in GitHub Actions, as they were in Swift CI. It may be possible to run them in GitHub Actions, but for now this PR gets the other unit tests running.

euanh added 3 commits March 10, 2025 11:30
@euanh
workflows: Re-enable tests job
f41c60a
@euanh
workflows: Disable tests on Windows
f300416 
Requires NIO support on Windows
@euanh
workflows: Disable end-to-end tests in GitHub Actions
fe38e48 
There is a good chance that GitHub Actions will be able to run these tests,
but we will disable them for now in order to get the unit tests running.
The end-to-end tests could not run with swift-ci, so disabling them here
does not reduce CI coverage.
@euanh euanh added test suite Changes to generator's test suite no functional change continuous integration Changes to CI workflows and removed test suite Changes to generator's test suite no functional change labels Mar 10, 2025
@euanh
Copy link
Contributor Author

euanh commented Mar 10, 2025

@swift-ci test

@euanh euanh changed the title workflows: Re-enable tests job workflows: Run unit tests using GitHub Actions Mar 10, 2025
@euanh euanh marked this pull request as ready for review March 10, 2025 12:06
@euanh euanh requested a review from MaxDesiatov as a code owner March 10, 2025 12:06
MaxDesiatov
MaxDesiatov approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@euanh euanh merged commit 4de34ce into swiftlang:main Mar 10, 2025
19 checks passed
@euanh euanh deleted the github-actions-support branch March 10, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
continuous integration Changes to CI workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@euanh @MaxDesiatov