Symlink libclang_rt.builtins.a for Embedded Swift for WASI
#213
Conversation
Embedded Swift looks up clang compiler-rt in a different path than non-embedded. These paths could be normalized in the future, but for now the easiest fix seems to be just to symlink this static library.
| "usr/lib/swift/clang/lib/wasm32-unknown-wasip1" | ||
| ) | ||
|
|
||
| try await generator.createDirectoryIfNeeded(at: embeddedCompilerRTPath) |
There was a problem hiding this comment.
How about symlinking the platform directly itself instead of for each individual file?
There was a problem hiding this comment.
It expects libclang_rt.builtins.a, while the name of the symlinked file is libclang_rt.builtins-wasm32.a
There was a problem hiding this comment.
IIUC if we encode the arch name in the directory name, then it shouldn't be included in the file name, and vice versa. So different names for files are still needed.
There was a problem hiding this comment.
Hmm, I think the clang driver just prints error message while assuming the new per-target directory layout, but it also looks up the old layout. Could you try the directory symlink approach?
There was a problem hiding this comment.
That doesn't seem to work if symlinking wasm32-unknown-wasip1 to wasi is what you're suggesting:
> ls ~/.swiftpm/swift-sdks/swift-DEVELOPMENT-SNAPSHOT_wasm.artifactbundle/swift-DEVELOPMENT-SNAPSHOT_wasm/wasm32-unknown-wasi/swift.xctoolchain/usr/lib/swift/clang/lib/wasm32-unknown-wasip1
╭───┬──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┬──────┬──────────┬─────────────╮
│ # │ name │ type │ size │ modified │
├───┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼──────┼──────────┼─────────────┤
│ 0 │ /home/mdesiatov/.swiftpm/swift-sdks/swift-DEVELOPMENT-SNAPSHOT_wasm.artifactbundle/swift-DEVELOPMENT-SNAPSHOT_wasm/wasm32-unknown-wasi/swift.xctoolchain/usr/lib/swift/clang/lib/wasm32-unknown-wasip1/libclang_rt.builtins-wasm32.a │ file │ 306.4 kB │ an hour ago │
╰───┴──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┴──────┴──────────┴─────────────╯
> swift build --swift-sdk swift-DEVELOPMENT-SNAPSHOT_wasm-embedded -c release
Building for production...
wasm-ld: error: cannot open /home/mdesiatov/.swiftpm/swift-sdks/swift-DEVELOPMENT-SNAPSHOT_wasm.artifactbundle/swift-DEVELOPMENT-SNAPSHOT_wasm/wasm32-unknown-wasi/swift.xctoolchain/usr/lib/swift/clang/lib/wasm32-unknown-wasip1/libclang_rt.builtins.a: No such file or directory
There was a problem hiding this comment.
Ah, I meant symlinking wasip1 to wasi.
There was a problem hiding this comment.
Yes, that worked, thanks!
|
@swift-ci test |
|
@swift-ci test |
Embedded Swift looks up Clang's compiler-rt static library in a different path than non-embedded. These paths could be normalized in the future, but for now the easiest fix seems to be just to symlink the directory the static library is located in.