Don't filter results when opening a codecompletion session #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filtering the results in SourceKit takes considerable time, which we are not really interested in measuring. Retrieve the initial set of results without a filter text with a result limit of 200. If we need to check for an expected result, perform a subsequent code completion update that sets the filter text. Don't measure the performance of that request.
bnbarham
approved these changes
Jan 13, 2022
Comment on lines
+257
to
+258
| // Set expected results to 200 to avoid inflating the time measurements by serialization time. | ||
| // To make sure that the expected result is in the results, filter by its base name. |
|
|
||
| let reusingASTContext = openResponse.value.getBool(.key_ReusingASTContext) | ||
|
|
||
| if let expectedResult = expectedResult { |
There was a problem hiding this comment.
Will be interesting to see how much slower the extra request makes it.
There was a problem hiding this comment.
I would expect that the update should be pretty fast, but let’s see. I started a stress tester run via swiftlang/swift#37710.
|
@swift-ci Please test |
|
Doesn’t seem to have made a measurable runtime difference for the stress tester. Execution of https://ci.swift.org/job/swift-PR-macos-with-sourcekit-stress-tester/78/ finished in 10 hours, which matches previous runs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filtering the results in SourceKit takes considerable time, which we are not really interested in measuring.
Retrieve the initial set of results without a filter text with a result limit of 200. If we need to check for an expected result, perform a subsequent code completion update that sets the filter text. Don't measure the performance of that request.