Fix bugs found by mutating source in SwiftParserTest using alternative token choices #1341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…have leading trivia
…ate after `resetForSplit`
|
@swift-ci Please test |
bnbarham
approved these changes
Feb 14, 2023
Comment on lines
+1663
to
+1665
| DiagnosticSpec(locationMarker: "1️⃣", message: "expected value and ')' to end tuple"), | ||
| DiagnosticSpec(locationMarker: "2️⃣", message: #"unexpected code '"""' in string literal"#), | ||
| DiagnosticSpec(locationMarker: "3️⃣", message: #"expected '"""' to end string literal"#), |
There was a problem hiding this comment.
Feels like the """ should be a strong marker that an interpolation is unterminated. But I'm all for this vs an infinite loop 😅.
| @@ -1612,11 +1613,12 @@ extension Parser { | |||
| modifier = nil | |||
| } | |||
|
|
|||
| let introducer = self.eat(handle) | |||
|
Most of these seem worth cherry-picking to 5.8 (the infinite loop ones at the very least). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of fixes for bugs that I found using the technique in #1340.