fixed testAvailabilityQuery34 and testAvailabilityQueryUnavailability28 #1423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
reviewed
Mar 19, 2023
58 tasks
ahoppen
reviewed
Mar 20, 2023
There was a problem hiding this comment.
Thanks for the pull request. This is looking good already. I’d prefer to implement the recovery inside the parser instead of ParseDiagnosticGenerator.swift though because that allows us to form a SwiftSyntax tree that still represents the code the user intended to write.
So, wherever we currently parse the >= as unexpected tokens, I would consume the >= as unexpected text and then continue parsing 10.51 as a version.
Could you try that? If something doesn’t make sense to you, let me know.
|
Hope I understood the request, let me know if we can do better |
ahoppen
reviewed
Mar 21, 2023
|
I had a little problem with source control 😅 now everything should be ok |
ahoppen
approved these changes
Mar 21, 2023
CippoX
force-pushed
the
availability-query-tests-version-comparison
branch
from
36272e8 to
55349f8
Compare
|
@ahoppen I'm sorry but looks like something went wrong, I've opened a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first fix attempt for this repo. I hope I'm heading in the right direction.