-
Notifications
You must be signed in to change notification settings - Fork 439
Remove SwiftSyntaxParser module #1544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SwiftSyntaxParser module #1544
Conversation
@swift-ci Please test macOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
@@ -1,3 +0,0 @@ | |||
// A closure without a signature. The test will ensure it stays the same after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked through all these, but I assume you moved ones you thought necessary and deleted otherwise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, most of them became initializers calls to create syntax trees.
/// } | ||
/// ``` | ||
/// | ||
/// The source file is hard-coded so this test case doesn't need to depend on the parser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some reason not to depend on the parser here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s just that this test is in SwiftSyntaxTest
and I don’t think we should be depending on the parser from SwiftSyntaxTest
because it’s lower level. Also, it didn’t make any sense for me to move this file to SwiftParserTest
because that’s not where it belongs, so I ended up with this solution, which I don’t find super terrible.
8e204f6
to
0484816
Compare
0484816
to
3ac1944
Compare
This removes the `SwiftSyntaxParser` module, which was just a wrapper around `SwiftParser` to ease the transition for clients that previously used `SwiftSyntaxParser`. Everybody should be using `SwiftParser` by now, so remove the deprecated module. This migrates all test cases that still provide value to other modules.
3ac1944
to
b79e559
Compare
@swift-ci Please test |
@swift-ci Please test Windows |
…ntaxparser Remove SwiftSyntaxParser module
…ntaxparser Remove SwiftSyntaxParser module
This removes the
SwiftSyntaxParser
module, which was just a wrapper aroundSwiftParser
to ease the transition for clients that previously usedSwiftSyntaxParser
. Everybody should be usingSwiftParser
by now, so remove the deprecated module.This migrates all test cases that still provide value to other modules.