Remove SwiftSyntaxParser module #1544
Conversation
|
@swift-ci Please test macOS |
| @@ -1,3 +0,0 @@ | |||
| // A closure without a signature. The test will ensure it stays the same after | |||
There was a problem hiding this comment.
I haven't looked through all these, but I assume you moved ones you thought necessary and deleted otherwise?
There was a problem hiding this comment.
Yes, most of them became initializers calls to create syntax trees.
| /// } | ||
| /// ``` | ||
| /// | ||
| /// The source file is hard-coded so this test case doesn't need to depend on the parser. |
There was a problem hiding this comment.
Is there some reason not to depend on the parser here?
There was a problem hiding this comment.
It’s just that this test is in SwiftSyntaxTest and I don’t think we should be depending on the parser from SwiftSyntaxTest because it’s lower level. Also, it didn’t make any sense for me to move this file to SwiftParserTest because that’s not where it belongs, so I ended up with this solution, which I don’t find super terrible.
ahoppen
force-pushed
the
ahoppen/remove-swiftsyntaxparser
branch
from
8e204f6 to
0484816
Compare
ahoppen
changed the title
ahoppen
force-pushed
the
ahoppen/remove-swiftsyntaxparser
branch
from
0484816 to
3ac1944
Compare
ahoppen
changed the title
This removes the `SwiftSyntaxParser` module, which was just a wrapper around `SwiftParser` to ease the transition for clients that previously used `SwiftSyntaxParser`. Everybody should be using `SwiftParser` by now, so remove the deprecated module. This migrates all test cases that still provide value to other modules.
ahoppen
force-pushed
the
ahoppen/remove-swiftsyntaxparser
branch
from
3ac1944 to
b79e559
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
…ntaxparser Remove SwiftSyntaxParser module
…ntaxparser Remove SwiftSyntaxParser module
This removes the
SwiftSyntaxParsermodule, which was just a wrapper aroundSwiftParserto ease the transition for clients that previously usedSwiftSyntaxParser. Everybody should be usingSwiftParserby now, so remove the deprecated module.This migrates all test cases that still provide value to other modules.